add redmi k30 pro #6256
Closed
add redmi k30 pro #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuweiyuan8
requested review from
amazingfate,
a team,
igorpecovnik,
rpardini and
hzyitc
as code owners
github-actions
bot
added
size/large
amazingfate
requested changes
Feb 6, 2024
viraniac
previously requested changes
Feb 6, 2024
viraniac
reviewed
Feb 7, 2024
viraniac
dismissed
their stale review
the requested changes are added, hence dismissing the old review
|
Based on quick look. Looks good to me. @amazingfate as you also requested some changes hence asking this. Does it look good to you too? |
amazingfate
requested changes
Feb 7, 2024
Comment on lines
+4
to
+9
| case $machine_model in | ||
| "Redmi k30 pro (SMS)") | ||
| panel_type=sms | ||
| ;; | ||
| "Redmi k30 pro (CSOT)") | ||
| panel_type=csot |
There was a problem hiding this comment.
Model is define as Redmi k30 pro (lmi) in devicetree, I think this will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Jira reference number [AR-9999]
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist: